fix duplicate 3D orientation canvas in iframe - #4134
Closed
imrishabh18 wants to merge 1 commit into
Closed
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Member
Author
|
Superseded by the root-cause fix in tscircuit/3d-viewer#958. React 19 Strict Mode clears the orientation component's DOM ref before passive-effect cleanup. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
The standalone iframe entrypoint wrapped
IframeAppinReact.StrictMode. Strict Mode replays effects, while@tscircuit/3d-viewercreates its orientation canvas imperatively. In the iframe build this left two 120×120 canvases in the orientation-control container: a stale canvas at the top and the real view cube pushed down by 120px.The production iframe does not need Strict Mode, so mounting
IframeApponce avoids replaying this imperative integration.Validation
bun test— 34 tests passedbun run format:checkbun run build:iframeexample09-iframe.fixture.tsx: orientation container changed from two canvases to one, and the stray box disappeared